Re: [Xen-devel] [PATCH v6 05/10] libxl: vnuma topology configuration parser and doc

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-07-18 at 01:50 -0400, Elena Ufimtseva wrote:
> diff --git a/tools/libxl/libxl_vnuma.h b/tools/libxl/libxl_vnuma.h
> new file mode 100644
> index 0000000..4ff4c57
> --- /dev/null
> +++ b/tools/libxl/libxl_vnuma.h
> @@ -0,0 +1,8 @@

Needs the normal guards against repeated inclusion.

Is this intended to be an internal header? If it is to be used by
applications then the things which it defines should be correctly
namespaced.

> +#include "libxl_osdeps.h" /* must come before any other headers */
> +
> +#define VNUMA_NO_NODE ~((unsigned int)0)
> +
> +/* Max vNUMA node size from Linux. */
> +#define MIN_VNODE_SIZE  32U
> +
> +#define MAX_VNUMA_NODES (unsigned int)1 << 10

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel