Re: [Xen-devel] [PATCH v6 05/10] libxl: vnuma topology configuration parser and doc

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-07-18 at 01:50 -0400, Elena Ufimtseva wrote:
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index de25f42..5876822 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -318,7 +318,11 @@ libxl_domain_build_info = Struct("domain_build_info",[
>      ("disable_migrate", libxl_defbool),
>      ("cpuid",           libxl_cpuid_policy_list),
>      ("blkdev_start",    string),
> -    
> +    ("vnuma_mem",     Array(uint64, "nr_nodes")),
> +    ("vnuma_vcpumap",     Array(uint32, "nr_nodemap")),
> +    ("vdistance",        Array(uint32, "nr_dist")),
> +    ("vnuma_vnodemap",  Array(uint32, "nr_node_to_pnode")),

Alignment of the Array please.

Also tools/libxl/idl.txt says:

  idl.Array.len_var contains an idl.Field which is added to the parent
  idl.Aggregate and will contain the length of the array. The field
  MUST be named num_ARRAYNAME.

So these need to be nr_vmuma_mem etc.

You also need to add a LIBXL_HAVE_* define to libxl.h to flag the
availability of this interface to the consumers. (Only add the define,
neither libxl nor xl should consume it, it's for external users only)

This series seems to add the libxl interface changes and the xl
consumer, but not the actual libxl implementation. I think you probably
need to reorder the series a bit. Normally we would want to see the
libxl changes (headers and implementation) first followed by the xl
change to use the new interface.

> diff --git a/tools/libxl/libxl_vnuma.h b/tools/libxl/libxl_vnuma.h
> new file mode 100644
> index 0000000..4ff4c57
> --- /dev/null
> +++ b/tools/libxl/libxl_vnuma.h
> @@ -0,0 +1,8 @@
> +#include "libxl_osdeps.h" /* must come before any other headers */
> +
> +#define VNUMA_NO_NODE ~((unsigned int)0)
> +
> +/* Max vNUMA node size from Linux. */
> +#define MIN_VNODE_SIZE  32U

Max or min?

> +
> +#define MAX_VNUMA_NODES (unsigned int)1 << 10



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel