Re: [Xen-devel] [PATCH v8 4/7] xen/arm: Add virtual GICv3 support

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 07/28/2014 05:25 PM, Ian Campbell wrote:
> On Mon, 2014-07-28 at 17:11 +0100, Julien Grall wrote:
> 
>> It might be worse to add a check in Xen that ICC_SRE_EL3 as the SRE bit
>> enabled.
> 
> I don't think it is readable from EL2.

Oh yes.

FWIW, the Linux documentation say:

"For systems with a GICv3 interrupt controller:
  - If EL3 is present:
    ICC_SRE_EL3.Enable (bit 3) must be initialiased to 0b1.
    ICC_SRE_EL3.SRE (bit 0) must be initialised to 0b1.
  - If the kernel is entered at EL1:
    ICC.SRE_EL2.Enable (bit 3) must be initialised to 0b1
    ICC_SRE_EL2.SRE (bit 0) must be initialised to 0b1.
"

I guess if the firmware doesn't set up correctly those values, then it's
the problem of the firmware developper.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel