[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2 01/12] Create efi-shared.[ch], and move string functions

>>> On 28.07.14 at 18:04, <Ian.Campbell@xxxxxxxxxx> wrote:
> On Mon, 2014-07-28 at 17:00 +0100, Jan Beulich wrote:
>> >>> On 28.07.14 at 17:56, <Ian.Campbell@xxxxxxxxxx> wrote:
>> > On Mon, 2014-07-28 at 16:52 +0100, Jan Beulich wrote:
>> >> > Even if not it looks like ~20K of mostly __init stuff, which doesn't
>> >> > seem like the end of the world, especially given that more and more
>> >> > toolstacks do support EFI with time.
>> >> 
>> >> Right now - with the runtime code not moved over yet - it's
>> >> mostly __init. Plus (with the linker not being able to discard that
>> >> code) it carries the risk of having references to symbols that
>> >> don't exist in the non-EFI build.
>> > 
>> > Perhaps we can put the relevant code into efi specific sections and DTRT
>> > in xen.lds.S?
>> Maybe it could be made work, but I'd be wary of linker version issues
>> then.
> Rather than arch .c files including common .c (or .inc) files how about
> making xen/arch/*/efi/Makefile link xen/commmon/efi/built-in.o into it's
> own built-in.o instead of having xen/common/Makefile do it like would
> normally happen?

That's an option. But I agree the inclusion of .c in another .c isn't
really nice; I would therefore anyway favor a (set of) arch header
file(s) providing everything the common code can't do on its own.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.