[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2 01/12] Create efi-shared.[ch], and move string functions

On Wed, 2014-07-23 at 17:31 +0100, Jan Beulich wrote:
> > -static EFI_BOOT_SERVICES *__initdata efi_bs;
> >  static EFI_HANDLE __initdata efi_ih;
> >  
> > -static SIMPLE_TEXT_OUTPUT_INTERFACE *__initdata StdOut;
> > -static SIMPLE_TEXT_OUTPUT_INTERFACE *__initdata StdErr;
> In the end I'm not really happy anyway with them becoming non-
> static - rather than building separate .o-s in the common efi/
> directory, would it not be possible to just have the .c files there,
> but include them from the arch ones?

That alternative seems pretty gross to me, what is the problem with a
global EfiStdOut or something like that?

>  This would also address the
> tool chain detection issue you described in the cover letter (without
> the addressing of which I can't see how things will ultimately work).

In the case where the toolchain doesn't EFI won't the unnecessary code
built in xen/common/efi simply get discarded by the linker?

Even if not it looks like ~20K of mostly __init stuff, which doesn't
seem like the end of the world, especially given that more and more
toolstacks do support EFI with time.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.