Re: [Xen-devel] [ARM:PATCH v1 1/1] Add Odroid-XU (Exynos5410) support

[Suriyan Ramasami <suriyan.r@xxxxxxxxx>]

Thanks Ian/Julien for the reviews and corrections. Much appreciated.

I shall rework the code based on all your suggestions.

Ian, as you pointed out, I will move the EXYNOS5410_PA_SYSRAM setting
in smp_init, moving the power up sequence to a cpu_up call. This way,
cpu_up will be called for each cpu as mentioned in the dtb, removing
the hardcoding that Julien referred to.

I shall also use the read*/write* helpers mentioned by Julien, and
shall abide by the XEN coding style.

Please await my Patch version 2.

Thanks as usual
- Suriyan

PS: I have noticed that there is no ARM port of XEN having more than 2
CPUs. Is that correct? I am mentioning this, cause with the XU, though
I can bring up all 4 processors in XEN and in dom0, domU fails to make
much boot progress when it is xl created. I am able to boot domU, if I
restrict the dtb for dom0 to 2 CPUs.


On Fri, Jul 25, 2014 at 5:39 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Fri, 2014-07-25 at 13:19 +0100, Julien Grall wrote:
>
>> > +       dprintk(XENLOG_INFO, "Waiting for power status to change to %d\n",
>> > +               EXYNOS5410_POWER_ENABLE);
>> > +       while (c[4] != EXYNOS5410_POWER_ENABLE) {
>>
>> The Xen coding style request the "{" to be on a newline.
>
> Oh and spaces inside the ()'s for whiles and the for which was above.
> e.g.
>
>         while ( c[4] != EXYNOS5410_POWER_ENABLE )
>         {
>
> Plus c[4] should as Julien mentioned be a read*().
>
> Ian.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel