Re: [Xen-devel] [ARM:PATCH v1 1/1] Add Odroid-XU (Exynos5410) support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-07-25 at 13:19 +0100, Julien Grall wrote:

> > +       dprintk(XENLOG_INFO, "Waiting for power status to change to %d\n",
> > +               EXYNOS5410_POWER_ENABLE);
> > +       while (c[4] != EXYNOS5410_POWER_ENABLE) {
> 
> The Xen coding style request the "{" to be on a newline.

Oh and spaces inside the ()'s for whiles and the for which was above.
e.g.

        while ( c[4] != EXYNOS5410_POWER_ENABLE )
        {

Plus c[4] should as Julien mentioned be a read*().

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel