[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH RESEND v9 08/14] xen/x86: factor out map and unmap from the memory_mapping DOMCTL
On 07/23/2014 01:59 PM, Jan Beulich wrote: >>>> On 14.07.14 at 02:50, <avanzini.arianna@xxxxxxxxx> wrote: >> v9: >> - Don't ignore an error if it doesn't happen while unmapping the last >> I/O-memory mapping in unmap_mmio_regions() for x86. >> - Fix wrong argument in the call to unmap_mmio_regions() performed on >> failure by map_mmio_regions() for x86. >> - Explicitly specify nr_mfns in the commit message emitted when the >> function map_mmio_regions() fails in the DOMCTL handling code. >> - Change "nr_mfns" to "nr" in the arch-specific map/unmap functions >> for x86. > > A "resend" with actual changes is kind of odd anyway, and sadly > you didn't also address the coding style problems here which I > has pointed out on the original v9. That means you won't get > around sending a v10... > Thank you for your feedback. The changes above are related to the original v9 ([1]); in the resend I only rebased the patchset on top of the latest ARM-related changes. So, something actually changed, mostly in the first patches, but it was only what was instrumental to let the patchset apply and compile on top of those ARM-related GIC and p2m changes. I'm sorry if it was not clear, most probably there is some more appropriate tag for a patchset with such a purpose. As of v10, I am working on it, and I have done my best to address the very important coding style problems you pointed out; the reason why I haven't sent it yet is that, due to my lack of experience, I am having some fun finding out a way to pipe up to libxl information about the class of PCI devices. I however hope to be proposing it very soon. Thank you, Arianna [1] http://markmail.org/message/h4upm4ve7n7h4bnk > Jan > -- /* * Arianna Avanzini * avanzini.arianna@xxxxxxxxx * 73628@xxxxxxxxxxxxxxxxxxx */ _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |