[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RESEND v9 08/14] xen/x86: factor out map and unmap from the memory_mapping DOMCTL



>>> On 14.07.14 at 02:50, <avanzini.arianna@xxxxxxxxx> wrote:
>     v9:
>         - Don't ignore an error if it doesn't happen while unmapping the last
>           I/O-memory mapping in unmap_mmio_regions() for x86.
>         - Fix wrong argument in the call to unmap_mmio_regions() performed on
>           failure by map_mmio_regions() for x86.
>         - Explicitly specify nr_mfns in the commit message emitted when the
>           function map_mmio_regions() fails in the DOMCTL handling code.
>         - Change "nr_mfns" to "nr" in the arch-specific map/unmap functions
>           for x86.

A "resend" with actual changes is kind of odd anyway, and sadly
you didn't also address the coding style problems here which I
has pointed out on the original v9. That means you won't get
around sending a v10...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.