[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 3/3] stubdom: fix -Wextra usage in vtpm_emulator
Olaf Hering, le Tue 22 Jul 2014 09:19:17 +0200, a écrit : > If -Wextra is appended to CFLAGS it will enable all warnings. Previous > options such as -Wno-unused-parameters have no effect anymore. As a > result compilation will fail with gcc-4.3. Newer versions of gcc will > appearently remember -Wno-* options before -Wextra. > Rearrange warning options for gcc so that -Wextra comes before other -W > options. This fixes compilation of stubdom in SLES11. > > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx> Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> > --- > stubdom/Makefile | 1 + > stubdom/vtpm-cmake-Wextra.patch | 21 +++++++++++++++++++++ > 2 files changed, 22 insertions(+) > create mode 100644 stubdom/vtpm-cmake-Wextra.patch > > diff --git a/stubdom/Makefile b/stubdom/Makefile > index 5f25c20..333112c 100644 > --- a/stubdom/Makefile > +++ b/stubdom/Makefile > @@ -210,6 +210,7 @@ tpm_emulator-$(XEN_TARGET_ARCH): > tpm_emulator-$(TPMEMU_VERSION).tar.gz > patch -d $@ -p1 < vtpm-locality.patch > patch -d $@ -p1 < vtpm-parent-sign-ek.patch > patch -d $@ -p1 < vtpm-deepquote.patch > + patch -d $@ -p1 < vtpm-cmake-Wextra.patch > mkdir $@/build > cd $@/build; CC=${CC} $(CMAKE) .. -DCMAKE_C_FLAGS:STRING="-std=c99 > -DTPM_NO_EXTERN $(TARGET_CPPFLAGS) $(TARGET_CFLAGS) > -Wno-declaration-after-statement" > touch $@ > diff --git a/stubdom/vtpm-cmake-Wextra.patch b/stubdom/vtpm-cmake-Wextra.patch > new file mode 100644 > index 0000000..a603654 > --- /dev/null > +++ b/stubdom/vtpm-cmake-Wextra.patch > @@ -0,0 +1,21 @@ > +--- > + CMakeLists.txt | 3 ++- > + 1 file changed, 2 insertions(+), 1 deletion(-) > + > +Index: tpm_emulator-x86_64/CMakeLists.txt > +=================================================================== > +--- tpm_emulator-x86_64.orig/CMakeLists.txt > ++++ tpm_emulator-x86_64/CMakeLists.txt > +@@ -40,10 +40,11 @@ set(TPM_STORAGE_NAME "/var/lib/tpm/tpm_e > + set(TPM_DEVICE_NAME "/dev/tpm") > + endif() > + configure_file(${CMAKE_CURRENT_SOURCE_DIR}/config.h.in > ${CMAKE_CURRENT_BINARY_DIR}/config.h) > +-add_definitions(-Wall -Werror -Wno-unused-parameter -Wpointer-arith > -Wcast-align -Wwrite-strings) > ++add_definitions(-Wall -Werror) > + if("${CMAKE_SYSTEM}" MATCHES "Linux") > + add_definitions(-Wextra) > + endif() > ++add_definitions(-Wno-unused-parameter -Wpointer-arith -Wcast-align > -Wwrite-strings) > + if(USE_OPENSSL) > + add_definitions(-DUSE_OPENSSL) > + endif() > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxx > http://lists.xen.org/xen-devel > -- Samuel <A> sauf que le firewall bloque tout sauf internet -+- ben ouais, il bloque ipx/spx ! -+- _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |