Re: [Xen-devel] [PATCH 1/3] mini-os: tpm: fix array access in locality_enabled

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Olaf Hering, le Tue 22 Jul 2014 09:19:15 +0200, a écrit :
> gcc-4.3 fails to prove that array indices will remain positive. Add a
> hint for the compiler and check the index value before using it.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

> ---
>  extras/mini-os/tpm_tis.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/extras/mini-os/tpm_tis.c b/extras/mini-os/tpm_tis.c
> index e8ca69f..dc4134a 100644
> --- a/extras/mini-os/tpm_tis.c
> +++ b/extras/mini-os/tpm_tis.c
> @@ -611,7 +611,7 @@ s_time_t tpm_calc_ordinal_duration(struct tpm_chip *chip,
>  
>  
>  static int locality_enabled(struct tpm_chip* tpm, int l) {
> -   return tpm->enabled_localities & (1 << l);
> +   return l >= 0 && tpm->enabled_localities & (1 << l);
>  }
>  
>  static int check_locality(struct tpm_chip* tpm, int l) {
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 

-- 
Samuel
"2 + 2 = 5 pour d'assez grandes valeurs de 2"

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel