[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
- To: Greg KH <greg@xxxxxxxxx>
- From: Dave Airlie <airlied@xxxxxxxxx>
- Date: Sat, 19 Jul 2014 07:14:12 +1000
- Cc: linux-mips@xxxxxxxxxxxxxx, Linux Fbdev development list <linux-fbdev@xxxxxxxxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, dri-devel <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Benoit Taine <benoit.taine@xxxxxxx>, ath5k-devel@xxxxxxxxxxxxxxxx, linux-acenic@xxxxxxxxxx, Linux SCSI List <linux-scsi@xxxxxxxxxxxxxxx>, users@xxxxxxxxxxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, ath10k@xxxxxxxxxxxxxxxxxxx, linux-hippi@xxxxxxxxxx, industrypack-devel@xxxxxxxxxxxxxxxxxxxxx, Linux Wireless List <linux-wireless@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, MPT-FusionLinux.pdl@xxxxxxxxxxxxx, ath9k-devel@xxxxxxxxxxxxxxxx, wil6210@xxxxxxxxxxxxxxxx, linux-pcmcia@xxxxxxxxxxxxxxxxxxx, "John W. Linville" <linville@xxxxxxxxxxxxx>, linux-can@xxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, Network Development <netdev@xxxxxxxxxxxxxxx>, linux-mmc@xxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, e1000-devel@xxxxxxxxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 18 Jul 2014 21:14:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
>
> We have almost 1000 more uses of the non-macro version than the "macro"
> version in the kernel today:
> $ git grep -w DEFINE_PCI_DEVICE_TABLE | wc -l
> 262
> $ git grep "const struct pci_device_id" | wc -l
> 1254
did you check for non-const ones? just to see if we have any of the
broken case in the tree :-)
as for consistency, pci_dev vs usb_device :-P
Dave.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|