Re: [Xen-devel] [PATCH v1 08/10] libxl: introduce libxl_get_memory_static_max

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-07-17 at 13:02 +0100, Wei Liu wrote:
> On Thu, Jul 17, 2014 at 11:47:08AM +0100, Ian Campbell wrote:
> > On Thu, 2014-07-10 at 15:32 +0100, Wei Liu wrote:
> > > ... which returns the "static-max" knob of a domain. It will be used in
> > > later patch to retrieve memory static-max value of a domain.
> > > 
> > > As libxl_get_memory_{target, static_max} have similar logic, a macro is
> > > introduced to avoid code duplication.
> > 
> > It looks to me like this could instead be a common helper function, with
> > a simple boolean parameter.
> > 
> 
> Ian J likes macro while you likes functions. I'm fine with anything that
> works. :-)

I think Ian prefers macros over repetition, but not at the expense of a
helper function. IOW macros only when the function is impossible. At
least I hope that's the case!

> Helper function it is.

You should probably check that Ian J doesn't disagree violently
first ;-)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel