Re: [Xen-devel] [PATCH v1 08/10] libxl: introduce libxl_get_memory_static_max

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jul 17, 2014 at 11:47:08AM +0100, Ian Campbell wrote:
> On Thu, 2014-07-10 at 15:32 +0100, Wei Liu wrote:
> > ... which returns the "static-max" knob of a domain. It will be used in
> > later patch to retrieve memory static-max value of a domain.
> > 
> > As libxl_get_memory_{target, static_max} have similar logic, a macro is
> > introduced to avoid code duplication.
> 
> It looks to me like this could instead be a common helper function, with
> a simple boolean parameter.
> 

Ian J likes macro while you likes functions. I'm fine with anything that
works. :-)

Helper function it is.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel