[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC V2 5/6] xen, libxc: Request page fault injection via libxc


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Thu, 17 Jul 2014 15:22:02 +0300
  • Cc: mdontu@xxxxxxxxxxxxxxx, tim@xxxxxxx, JBeulich@xxxxxxxx
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Thu, 17 Jul 2014 12:21:14 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=d078itdxmmiEJAQn5fIlNvZ/AgMNP07pTSXa9eaPPCADrgN4k5K/6clkF/DBlofdBJPCOfQR/npkIgflc+ceUykL079VATqMih81JQc1yqglp1+YuRFCuv+VoMYnPpdwWewj1k/1N/AaCl1sX2a/p3/f8OQmILavxnvscnDo14BhOluAZFQ1fLpZY2eVqkSML1EA4T1dYTxGZVfJCUEBox5o9futCTQL6/8hDKhdHR4JJ2mY7LG8TNzoIYFuk0OAWCpFmJQxyokN7Xa0//9EQ7pExPMpYfoxSvxwLF9Ei0kKfupsY00to2do1fmUxWi0L8REsCSMuBNWxQCd+5jyLA==; h=Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 07/11/2014 09:06 PM, Andrew Cooper wrote:
> On 11/07/14 16:43, Razvan Cojocaru wrote:
>> +         && !ctxt.pending_event
>> +         && ctxt.cr3 == d->fault_info.address_space )
>> +    {
>> +        /* Cache */
>> +        uint64_t virtual_address = d->fault_info.virtual_address;
>> +        uint32_t write_access = d->fault_info.write_access;
>> +
>> +        /* Reset */
>> +        d->fault_info.address_space = 0;
>> +        d->fault_info.virtual_address = 0;
>> +        d->fault_info.write_access = 0;
>> +
>> +        hvm_inject_page_fault((write_access << 1) | PFEC_user_mode,
> 
> It is sensible in the slightest to have write_access shifted by 1 with
> respect to a real pagefault error code?

I'm not sure I follow this comment. Could you please elaborate a bit more?


Thanks,
Razvan Cojocaru

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.