[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 5/5] make: Make "src-tarball" target actually make a source tarball
On Wed, 2014-07-16 at 18:45 +0100, George Dunlap wrote: > On 07/16/2014 05:56 PM, Ian Campbell wrote: > > On Wed, 2014-07-16 at 16:06 +0100, Ian Jackson wrote: > >> George Dunlap writes ("[PATCH 5/5] make: Make "src-tarball" target > >> actually make a source tarball"): > >>> At the moment, making a release tarball is an annoyingly manual > >>> process that involves running "git archive" into a temporary directory. > >> ... > >>> +src-tarball: subtree-update > >>> + bash ./tools/misc/mktarball $(XEN_ROOT) $$(git describe) > >> > >> Does this absolutely have to depend on subtree-update ? Perhaps we > >> need a new "make the subtrees exist" target ? > > > > Given that he makes the force targets depend on the dir targets in one > > of the earlier patches I think subtree-update might already be that > > target... > > I think he might have been thinking that it would be nice to be able to > make a tarball without doing the force update -- i.e., if you had > checked out a particular version of one of the trees, just use that; but > if you hadn't checked anything out, go fetch the tree. > > I could do that. :-) It means SOP would have to be two steps "make > subdir-update ; make src-tarball-release". Personally I think it's a > bit of a trap waiting to happen, but I can see the logic behind it. It's a bit niche perhaps, so perhaps make it so you can do make src-tarball-release FORCE_CURRENT_SUBTREES=1 by conditionalising the dep? Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |