Re: [Xen-devel] [PATCH ARM v6 04/14] mini-os: headers for ARM

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Thomas,

On 16/07/14 12:07, Thomas Leonard wrote:
> diff --git a/extras/mini-os/include/arm/os.h b/extras/mini-os/include/arm/os.h
> new file mode 100644
> index 0000000..6a1cc37
> --- /dev/null
> +++ b/extras/mini-os/include/arm/os.h
> @@ -0,0 +1,216 @@
> +#ifndef _OS_H_
> +#define _OS_H_
> +
> +#ifndef __ASSEMBLY__
> +
> +#include <mini-os/hypervisor.h>
> +#include <mini-os/types.h>
> +#include <mini-os/compiler.h>
> +#include <mini-os/kernel.h>
> +#include <xen/xen.h>
> +
> +void arch_fini(void);
> +void timer_handler(evtchn_port_t port, struct pt_regs *regs, void *ign);
> +
> +extern void *device_tree;
> +
> +#define BUG() while(1){asm volatile (".word 0xe7f000f0\n");} /* Undefined 
> instruction; will call our fault handler. */
NIT: I would explain that ARM doesn't provide any undefined instruction 
so we use an encoding that is invalid on ARMv7.
The other part of this patch looks good to me.

FWIW: Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel