Re: [Xen-devel] [libvirt] [PATCH] libxl: Implement basic video device selection

[Eric Blake <eblake@xxxxxxxxxx>]

On 07/16/2014 03:05 PM, Jim Fehlig wrote:

>> +        b_info->video_memkb = def->videos[0]->vram ?
>> +                              def->videos[0]->vram :
>> +                              LIBXL_MEMKB_DEFAULT;
>>   
> 
> While testing this, I noticed that libvirt will set vram to 9216 if not
> specified.  E.g.

The 9216 default for qemu is absolutely stupid.  No real hardware has a
limit of 9M (8M or 16M are more likely).  Please feel free to not
perpetuate that stupidity into libxl.


> With type='vga', libxl will then fail to start the domain
> 
> libxl: error: libxl_create.c:253:libxl__domain_build_info_setdefault:
> videoram must be at least 16 MB for STDVGA on QEMU_XEN
> 
> This could be handled in libxlDomainDeviceDefPostParse(), where we can
> check for sane vram values for the various VIR_DOMAIN_VIDEO_TYPE_*, or
> set sane defaults if vram is not specified.

Sounds like for libxl, a sane default is 16M.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel