Re: [Xen-devel] [PATCH 3/3] Use the new include subdirectories to build Xen tools

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-07-11 at 13:46 +0100, Stefano Stabellini wrote:
> On Thu, 10 Jul 2014, Ian Campbell wrote:
> > On Thu, 2014-07-10 at 17:16 +0100, Stefano Stabellini wrote:
> > > Use them to build qemu-xen.
> > > 
> > > Add them to the include path of CFLAGS_libxenguest, CFLAGS_libxenctrl
> > > and CFLAGS_libxenstore.
> > > 
> > > Use CFLAGS_libxenctrl and CFLAGS_libxenstore to build the python tools.
> > 
> > All of these should be included in the patches which do the moves,
> > otherwise you break bisectability.
> 
> I'll send out a single big patch.
> 
> 
> > and I think you can drop -I$(XEN_XENSTORE) -I$(XEN_LIBXC) etc since
> > those are supposed to be xenstore-internal headers, which oughtn't to be
> > used even by intree users of the library.
> > 
> > If doing that breaks the build we should look at why.
> 
> It does break the build.
> If we want to go down that path, we need to move xc_dom.h to
> libxc/include too. But then should we install it too?

This is because libxl and a few other bits use it I suppose?

It does strike me as a bit odd that this library isn't installed
already, although I suppose the set of people want to write a domain
builder directly is pretty small. But if you just wanted to move it and
not tackle that aspect at the same that would be OK IMHO.

> After that we still need to fix:
> 
[...]

All of these really have no business poking at the libxc internals
(especially xc_private.h) like that. (Or possibly some of the libxc
internals should be made public).

I don't think you should be expected to fix this now though.

> I could add I$(XEN_XENSTORE) and/or -I$(XEN_LIBXC) to the build line of
> these specific programs and avoid adding them to CFLAGS_libxenctrl and
> CFLAGS_libxenstore.

I think this is the right answer. It's in keeping with what Andrew did
to xen-mfndump in 7528dcd02de1. Please include a comment like:

# $FOO incorrectly uses libxc internals, which is naughty.

next to each one to mark it out (part of the reason for these is someone
got it wrong once and it spread via cut and paste I think).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel