[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/3] Use the new include subdirectories to build Xen tools

On Thu, 2014-07-10 at 17:16 +0100, Stefano Stabellini wrote:
> Use them to build qemu-xen.
> Add them to the include path of CFLAGS_libxenguest, CFLAGS_libxenctrl
> and CFLAGS_libxenstore.
> Use CFLAGS_libxenctrl and CFLAGS_libxenstore to build the python tools.

All of these should be included in the patches which do the moves,
otherwise you break bisectability.

and I think you can drop -I$(XEN_XENSTORE) -I$(XEN_LIBXC) etc since
those are supposed to be xenstore-internal headers, which oughtn't to be
used even by intree users of the library.

If doing that breaks the build we should look at why.

> diff --git a/tools/python/Makefile b/tools/python/Makefile
> index eee746d..7c4b281 100644
> --- a/tools/python/Makefile
> +++ b/tools/python/Makefile
> @@ -5,6 +5,8 @@ include $(XEN_ROOT)/tools/Rules.mk
>  all: build
>  XENPATH = "xen/util/path.py"
> +CFLAGS += $(CFLAGS_libxenctrl)
> +CFLAGS += $(CFLAGS_libxenstore)

You should be modifying tools/python/setup.py to change include_dirs for
the various modules instead of this.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.