[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH v2 5/7] Add cbs parameter support and removed sedf parameters with a LIBXL_API_VERSION gate from libxl.

On Fri, 2014-07-11 at 01:02 +0200, Dario Faggioli wrote:
> On gio, 2014-07-10 at 15:09 +0100, Ian Campbell wrote:
> > On Wed, 2014-07-09 at 16:55 -0400, Josh Whitehead wrote:
> > > From: Robbie VanVossen <robert.vanvossen@xxxxxxxxxxxxxxx>
> > > 
> > > We made an attempt at doing the versioning gate in this file.  Please let 
> > > us
> > > know if further changes are needed, and where they are needed to properly 
> > > guard
> > > the API.
> > 
> > I previously said that I thought it was fine to remove the obsolete SEDF
> > stuff from the libxl API.
> > 
> > However I mentioned this to the other maintainers and they disagreed
> > with me. The feeling is that an old application which used the old SEDF
> > parameters should continue to build but that trying to use those
> > parameters should result in an error.
> >
> Indeed. So, as far as this series is concerned, it looks like either the
> following solutions:
>  - introduce a new scheduler, with a new name, and deprecate SEDF all 
>    together
>  - keep the name and the full existing interface, but warn the user when
>    she touches one of the params that are no longer in use in the 
>    implementation
> would be ok.

Personally I think the former is preferable from both an implementation
point of view and from the pov of explaining it to users etc.

If the variations to the interface were very minor maybe the second
approach would work, but it looks to me like there is pretty much a
rewrite going on.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.