Re: [Xen-devel] [RFC PATCH v2 5/7] Add cbs parameter support and removed sedf parameters with a LIBXL_API_VERSION gate from libxl.

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On mer, 2014-07-09 at 16:55 -0400, Josh Whitehead wrote:
> From: Robbie VanVossen <robert.vanvossen@xxxxxxxxxxxxxxx>
> 
> We made an attempt at doing the versioning gate in this file.  Please let us
> know if further changes are needed, and where they are needed to properly 
> guard
> the API.
> 
So, since you're adding soft to libxl_domain_sched_params, so you need
to add something like:

/*
 * Some comments...
 */
#define LIBXL_HAVE_DOMAIN_SCHED_PARAMS_SOFT 1

in libxl.h.

Look at LIBXL_HAVE_DOMAIN_NODEAFFINITY,
LIBXL_HAVE_VCPUINFO_SOFT_AFFINITY for inspiration. :-)

If it were me, I think I'd include _SEDF_ in the name as well:

#define LIBXL_HAVE_DOMAIN_SCHED_SEDF_PARAMS_SOFT 1

or:

#define LIBXL_HAVE_DOMAIN_SCHEDPARAM_SEDF_SOFT 1

And I now see that Ian said plenty already in his email about
LIBXL_API_VERSION. I'll continue there...

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel