Re: [Xen-devel] [PATCH 0/3] move libxc and xenstore public headers to include subdir

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 0/3] move libxc and xenstore 
public headers to include subdir"):
> On Thu, 2014-07-10 at 17:36 +0100, Ian Jackson wrote:
> > It seems to me that, instead, these headers are (or should be) put
> > into dist/install/,
> 
> Definitely not. dist/install is an output directory which only some of
> our build runes create (basically those which are a shortcut for make
> install DESTDIR=dist)

Yes, that's what I meant.  I was using it as a shorthand for the
relevant part of DESTDIR.

> My build scripts for example don't use those rules, instead they do
>         make -C tools build
>         dir=$(mktemp -d /tmp/XXXXXX)
>         make tools-install DESTDIR=${dir}
> 
> Lots of distro packaging will do the same.

Well, then the out-of-tree things should be getting things from there.

> > and anything out-of-tree which needs them should
> > be looking for them there.
> 
> Properly out of tree things should get them from /usr/{local/,}include
> which is where they are installed.
> 
> This patch is about in-tree things and pseudo-in-tree things like
> tools/qemu-xen-dir. They are using -Itools/xenstore and picking up
> xenstore's internal headers alongside the public headers.

I agree that this is wrong.  But IMO it should be fixed by having
those things that can't cope (which should be only pseudo-in-tree
things as you put it) -I$(DESTDIR)/include (or whatever the real thing
is).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel