Re: [Xen-devel] [PATCH 0/3] move libxc and xenstore public headers to include subdir

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-07-10 at 17:36 +0100, Ian Jackson wrote:
> Stefano Stabellini writes ("[PATCH 0/3] move libxc and xenstore public 
> headers to include subdir"):
> > this patch series separates out the public libxc and xenstore headers
> > that are supposed to be usable by external programs, such as QEMU, from
> > the private internal headers.
> > 
> > The public headers are moved to a subdirectory called "include".
> > 
> > The headers move requires changes to a few Makefiles, one of which is
> > qemu-xen-traditional's (the patch to qemu-xen-traditional is sent
> > separately).
> > 
> > The series in its current form is not bisectable.
> 
> I don't think this is the right way to do this.
> 
> It seems to me that, instead, these headers are (or should be) put
> into dist/install/,

Definitely not. dist/install is an output directory which only some of
our build runes create (basically those which are a shortcut for make
install DESTDIR=dist)

My build scripts for example don't use those rules, instead they do
        make -C tools build
        dir=$(mktemp -d /tmp/XXXXXX)
        make tools-install DESTDIR=${dir}

Lots of distro packaging will do the same.

> and anything out-of-tree which needs them should
> be looking for them there.

Properly out of tree things should get them from /usr/{local/,}include
which is where they are installed.

This patch is about in-tree things and pseudo-in-tree things like
tools/qemu-xen-dir. They are using -Itools/xenstore and picking up
xenstore's internal headers alongside the public headers.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel