Re: [Xen-devel] [PATCH v9 1/8] libxl_internal: functions to check default values for builtin types

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-07-10 at 11:58 +0100, Wei Liu wrote:
> On Thu, Jul 10, 2014 at 11:19:44AM +0100, Ian Campbell wrote:
> > On Wed, 2014-07-09 at 10:45 +0100, Wei Liu wrote:
> > > +static inline int libxl__cpuid_policy_is_empty(libxl_cpuid_policy_list 
> > > *pl)
> > > +{
> > > +    return !libxl_cpuid_policy_list_length(pl);
> > > +}
> > 
> > Unfortunately on ARM I get
> > libxenlight_test.so: undefined reference to `libxl_cpuid_policy_list_length'
> > /local/scratch/ianc/devel/committer-arm32.git/tools/libxl/../../tools/libxl/libxenlight.so:
> >  undefined reference to `libxl_cpuid_policy_list_length'
> > 
> > So I think you need to move this one out of line into libxl_cpuid.c and
> > put a dummy version in libxl_nocpuid.c.
> > 
> > I can build test ARM the arm side for you, since I expect you don't have
> > the environment.
> > 
> 
> OIC, ARM doesn't have CPUID thing (yet) so it's compiled with
> libxl_nocpuid.c. Sorry for the trouble.
> 
> The following patch, which has libxl__cpuid_policy_is_empty moved to
> libxl_cpuid.c and libxl_nocpuid.c, assumes that when libxl_nocpuid.c is
> compiled, the given cpuid policy is always empty, so that the JSON
> output won't have cpuid policy.
> 
> Please try the following patch.

It worked fine, thanks.

I've applied this + the original #2..8.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel