[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC 2/9] xen: Optimize introspection access to guest state

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Thu, 10 Jul 2014 15:16:35 +0300
  • Cc: tim@xxxxxxx
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Thu, 10 Jul 2014 12:15:44 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=tFRot6NxqyKVcHIb+dZGN6y2EKvRLVMuAHf1y3clZBTaiEuiKV9fRc/KoNU/hllBlvSG+mdBh2Jlfbqmgj89qsXvDAUer2Kt8k0+rJUC2vyRZR8mRnOZcGzlAqxtzs9tYolxtl3avT5oQ37fK6JAjH1nM4sMVxwKy3vv59dSDiQWth5Jvql173eXjmkR8H4eAC5iUVLnh6Sv8wy9gGPyBJfzdqHewmrek+rzUP7XwcLekOJPsmqgEjWXYEMxM3P8eztpaRDm9GE3bSLr6zEtL2zVJW/Mt3iToZm59YFbwq06U0n16fAqs2WOog29UwHjfsEszNidGqW8kXuxFGkyLw==; h=Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 07/10/2014 02:57 PM, Razvan Cojocaru wrote:
> So this solution would appear to be a bit more involved than the initial
> solution. But you're, of course, right that guest_x86_mode should not be
> VMX-specific.
> Would it be OK if I would replace the call to vmx_guest_x86_mode() to a
> call to hvm_funcs.guest_x86_mode(v) (assuming that's possible)?

Actually, I probably misunderstood this, since "c->guest_x86_mode =
vmx_guest_x86_mode(v);" only happens in vmx.c, and p2m.c does
"req->regs.guest_x86_mode = hvm_guest_x86_mode(current);".

So I think extending this to SVM would simply require a change similar
to the one in vmx.c in svm.c (presumably in svm_vmcb_save(), with the
help of svm_guest_x86_mode()).

How does this tie any SVM extension of our work to VT-x internals?

Razvan Cojocaru

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.