[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v5 2/8] tools/libxc: pull min/max_t into xc_private.h
On Thu, 2014-07-10 at 12:01 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH v5 2/8] tools/libxc: pull min/max_t into > xc_private.h"): > > There are generally useful. > > Sorry for not spotting this but: names matching "*_t" are by the C > spec "reserved for the implementation". This is not a problem in the > hypervisor because that is compiled without the system headrs. Oh damn, yes of course. > In practice what this means is that it is possible that porting the > tools to a new platform might involve renaming these macros. So we > don't need to fix it right now unless we really feel like it. > > But we mustn't let the scope of these increase to include guest-side > code. I don't think there is any danger of that, there's no reason at all for this to be in e.g. xen/include/public. > (Also "min_t" is a very funny name for a function macro like this one. > To me it implies a type.) It's the _typed version of min I suppose, I think we've inherited this all the way from Linux without really considering the name... Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |