Re: [Xen-devel] [PATCH v8a 5/6] xen/arm: split vgic driver into generic and vgic-v2 driver

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 07/04/2014 08:01 AM, Vijay Kilari wrote:
>>> where vgic_emulate is implemented in vgic-v3.c rather than in vgic.c.
>>> The function will decode the register and then call vgic_send_sgi.
> 
>   The reason why vgic_emulate is kept in vgic-v3.c is because it is
> GICv3 specific
> and also the traps are landing in respective drivers. Ex: for GICv2
> write to GICD_SGIR
> is trapped in vgic-v2.c and similarly I expect for GICv3 is should be
> kept in GICv3.

Even though it's vGICv3 specific, vGICv2 will be handled sooner or later
on GICv3 platform.

Directly implement vgic_emulate in vgic-v3.c won't help to catch coding
error from Xen and may bring the hypervisor to segfault.

It could be the case if we forgot to disable system register trapping
(which I don't think you do) in the GICv3.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel