Re: [Xen-devel] [PATCH v6 1/5] xen/arm: Add support for GIC v3

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.07.14 at 08:19, <vijay.kilari@xxxxxxxxx> wrote:
> On Thu, Jul 3, 2014 at 2:39 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 03.07.14 at 10:37, <vijay.kilari@xxxxxxxxx> wrote:
>>> --- a/xen/include/xen/lib.h
>>> +++ b/xen/include/xen/lib.h
>>> @@ -67,6 +67,8 @@ do {
>>>     \
>>>
>>>  #define reserve_bootmem(_p,_l) ((void)0)
>>>
>>> +#define SZ_64K  0x00010000
>>> +
>>
>> What a strange definition? What's wrong with using the literal number
>> if indeed all you mean is "64k"?
> 
> Yes, these definitions are similar to include/linux/sizes.h in kernel

With no rationale at all given in the original commit's description. _If_
you really need this, explain why in a patch adding a sizes.h similar
to Linux'es instead of a random single item in a random place.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel