Re: [Xen-devel] [PATCH v8a 1/6] xen/arm: move and rename is_vcpu_running function to sched.h

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-07-03 at 10:12 +0100, Jan Beulich wrote:
> >>> On 03.07.14 at 10:34, <vijay.kilari@xxxxxxxxx> wrote:
> > +static inline bool_t is_vcpu_online(const struct vcpu *v)
> > +{
> > +    return !test_bit(_VPF_down, &v->pause_flags);
> > +}
> 
> Which now becomes a bit questionable a helper - it's not really helping
> much to wrap this ting test_bit() into an inline function. But if others
> like it, I'm not going to stand in the way.

I think it's ok to have these sorts of accessors, they make the
resulting calling if's a bit easier to reason about IMHO.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel