Re: [Xen-devel] [PATCH 01/11] mini-os: Make some headers more rumpkernel-friendly

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

(Fixed Keir's address.  Sorry, Keir.)

Andrew Cooper writes ("Re: [Xen-devel] [PATCH 01/11] mini-os: Make some headers 
more rumpkernel-friendly"):
> On 20/06/14 20:04, Ian Jackson wrote:
> > -#if __GNUC__ == 2 && __GNUC_MINOR__ < 96
> > -#define __builtin_expect(x, expected_value) (x)
> > -#endif
> > +#define smp_processor_id() 0
> >  #define unlikely(x)  __builtin_expect((x),0)
> >  #define likely(x)  __builtin_expect((x),1)
> 
> Not relevant to the patch itself, but as identified in c/s e5545fb6d0,
> these constructs are buggy.

Oh, yes.  Joy.  I don't propose to do anything about that in
rumpuser-xen's minios at this stage.

> > -#define smp_processor_id() 0
> > +#include <mini-os/hypervisor.h>
> > +
> > +#ifndef __RUMP_KERNEL__
> > +
> > +#if __GNUC__ == 2 && __GNUC_MINOR__ < 96
> > +#define __builtin_expect(x, expected_value) (x)
> > +#endif
> 
> Do we honestly care about compilers this old?

No.  This is just code motion, though.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel