Re: [Xen-devel] [PATCH v11 4/9] x86: detect and initialize Platform QoS Monitoring feature

["Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Friday, June 20, 2014 11:04 PM
> To: Xu, Dongxiao
> Cc: andrew.cooper3@xxxxxxxxxx; Ian.Campbell@xxxxxxxxxx;
> George.Dunlap@xxxxxxxxxxxxx; Ian.Jackson@xxxxxxxxxxxxx;
> stefano.stabellini@xxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxx;
> konrad.wilk@xxxxxxxxxx; dgdegra@xxxxxxxxxxxxx; keir@xxxxxxx
> Subject: Re: [PATCH v11 4/9] x86: detect and initialize Platform QoS 
> Monitoring
> feature
> 
> >>> On 20.06.14 at 16:31, <dongxiao.xu@xxxxxxxxx> wrote:
> > Detect platform QoS feature status and enumerate the resource types,
> > one of which is to monitor the L3 cache occupancy.
> >
> > Also introduce a Xen grub command line parameter to control the
> > QoS feature status.
> 
> "grub"?

Sorry, what's your point here? Not quite understand it...

> 
> > +static bool_t __initdata opt_pqos = 1;
> > +static bool_t __initdata opt_pqos_monitor = 1;
> 
> Hmm, did we really settle on enabling these by default?

Okay, I can disable it by default.

> 
> > +void __init init_platform_qos(void)
> > +{
> > +    if ( !opt_pqos )
> > +        return;
> > +
> > +    if ( opt_pqos_monitor && opt_rmid_max )
> 
> Kind of pointless to split the two if()-s.

The split is reserved for the following QoS features, such as CQE, etc.

Thanks,
Dongxiao

> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel