Re: [Xen-devel] [PATCH v11 4/9] x86: detect and initialize Platform QoS Monitoring feature

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.06.14 at 16:31, <dongxiao.xu@xxxxxxxxx> wrote:
> Detect platform QoS feature status and enumerate the resource types,
> one of which is to monitor the L3 cache occupancy.
> 
> Also introduce a Xen grub command line parameter to control the
> QoS feature status.

"grub"?

> +static bool_t __initdata opt_pqos = 1;
> +static bool_t __initdata opt_pqos_monitor = 1;

Hmm, did we really settle on enabling these by default?

> +void __init init_platform_qos(void)
> +{
> +    if ( !opt_pqos )
> +        return;
> +
> +    if ( opt_pqos_monitor && opt_rmid_max )

Kind of pointless to split the two if()-s.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel