Re: [Xen-devel] [PATCH ARM v4 12/12] mini-os: added ARM grant table initialisation

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Thomas,

On 06/18/2014 04:08 PM, Thomas Leonard wrote:
> +
> +/* Get Xen's sugggested physical page assignments for the grant table. */
> +static grant_entry_t *get_gnttab_base(void)
> +{
> +    int hypervisor;
> +
> +    hypervisor = fdt_path_offset(device_tree, "/hypervisor");

Same comment as on patch #11, you need to search the hypervisor node via
the compatible string.


> index 2f1b3d7..f395d12 100644
> --- a/extras/mini-os/gnttab.c
> +++ b/extras/mini-os/gnttab.c
> @@ -164,7 +164,7 @@ gnttabop_error(int16_t status)
>  {
>      status = -status;
>      if (status < 0 || status >= ARRAY_SIZE(gnttabop_error_msgs))
> -     return "bad status";
> +        return "bad status";

Spurious change?

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel