Re: [Xen-devel] [PATCH v9 5/9] libxl/xl: push VCPU affinity pinning down to libxl

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On mer, 2014-06-18 at 17:46 +0100, Ian Campbell wrote:
> On Wed, 2014-06-18 at 18:32 +0200, Dario Faggioli wrote:
> 
> > > > + * The number of libxl_bitmap in the array equals to the maximum number
> > > > + * of VCPUs. The size of each bitmap is computed basing on the maximum
> > > > + * number of PCPUs.
> > > 
> > > These are all things which the caller is expect to arrange by making
> > > appropriately sized allocations, not inherent properties of the API, I
> > > think.
> > > 
> > > So "the number of libxl_bitmap in the array *should* be equal". "The
> > > size of each bitmap should ..." etc.
> > > 
> > Will fix. I will also add a check that this is actually what we get from
> > the caller in libxl_dom.c (where the arrays are consumed).
> 
> Or define what will happen if the array is too short of the bitmaps not
> size appropriately.
> 
> I think it would be find to only pin the first N cpus for which an array
> entry is present and leave the rest floating, and likewise to simply
> assume any pcpus past the end of the bitmap are == 0.
> 
Sure. It's a bit trickier then to deal with both arrays (hard and soft)
at the same time, but it's probably worth a try.

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel