[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v9 5/9] libxl/xl: push VCPU affinity pinning down to libxl

On Wed, 2014-06-18 at 18:32 +0200, Dario Faggioli wrote:

> > > + * The number of libxl_bitmap in the array equals to the maximum number
> > > + * of VCPUs. The size of each bitmap is computed basing on the maximum
> > > + * number of PCPUs.
> > 
> > These are all things which the caller is expect to arrange by making
> > appropriately sized allocations, not inherent properties of the API, I
> > think.
> > 
> > So "the number of libxl_bitmap in the array *should* be equal". "The
> > size of each bitmap should ..." etc.
> > 
> Will fix. I will also add a check that this is actually what we get from
> the caller in libxl_dom.c (where the arrays are consumed).

Or define what will happen if the array is too short of the bitmaps not
size appropriately.

I think it would be find to only pin the first N cpus for which an array
entry is present and leave the rest floating, and likewise to simply
assume any pcpus past the end of the bitmap are == 0.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.