Re: [Xen-devel] [PATCH v5 06/21] xen/arm: segregate and split GIC low level functionality

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Vijay,

On 12/06/14 14:36, vijay.kilari@xxxxxxxxx wrote:
>   /*
> - * - needs to be called with a valid cpu_mask, ie each cpu in the mask has
> + * needs to be called with a valid cpu_mask, ie each cpu in the mask has
>    * already called gic_cpu_init
>    * - desc.lock must be held
>    * - arch.type must be valid (i.e != DT_IRQ_TYPE_INVALID)
> @@ -231,37 +103,7 @@ static void gic_set_irq_properties(struct irq_desc *desc,
>                                      const cpumask_t *cpu_mask,
>                                      unsigned int priority)
>   {

[..]

> -    ASSERT(type != DT_IRQ_TYPE_INVALID);
> -    ASSERT(spin_is_locked(&desc->lock));
Why did you drop these 2 ASSERTS? They should stay to help developer 
debugging wrong code...
Hence, it validates the assertion in the comments (see above).

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel