Re: [Xen-devel] [PATCH RFC 4/4] libxl: spawn a qemu to implement channels

[Dave Scott <Dave.Scott@xxxxxxxxxx>]

Hi Wei,

On 12 Jun 2014, at 13:11, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:

> On Wed, Jun 11, 2014 at 09:24:29PM +0100, David Scott wrote:
> [...]
>> +    for (i = 0; i < guest_config->num_channels; i++) {
>> +        flexarray_append(dm_args, "-chardev");
>> +        type = guest_config->channels[i].type;
>> +        path = guest_config->channels[i].path;
>> +        switch (type) {
>> +            case LIBXL_CHANNEL_TYPE_NONE:
>> +                flexarray_append(dm_args,
>> +                                 libxl__sprintf(gc, 
>> "null,id=libxl-channel%d",
>> +                                                    i));
> 
> Wouldn't it be more appropriate to use channels[i].devid?
> 
> And the indentation here seems wrong.
> 
> There's also a macro called GCSPRINTF that you can use.

Thanks for taking a look -- I’ll make a v2 which fixes these problems.

Thanks,
Dave
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel