Re: [Xen-devel] [PATCH RFC 4/4] libxl: spawn a qemu to implement channels

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jun 11, 2014 at 09:24:29PM +0100, David Scott wrote:
[...]
> +    for (i = 0; i < guest_config->num_channels; i++) {
> +        flexarray_append(dm_args, "-chardev");
> +        type = guest_config->channels[i].type;
> +        path = guest_config->channels[i].path;
> +        switch (type) {
> +            case LIBXL_CHANNEL_TYPE_NONE:
> +                flexarray_append(dm_args,
> +                                 libxl__sprintf(gc, 
> "null,id=libxl-channel%d",
> +                                                    i));

Wouldn't it be more appropriate to use channels[i].devid?

And the indentation here seems wrong.

There's also a macro called GCSPRINTF that you can use.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel