Re: [Xen-devel] [PATCH v2 01/17] configure: make the libaio test conditional on blktap1

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

On 05/06/14 17:06, Ian Campbell wrote:
> On Mon, 2014-06-02 at 17:08 +0200, Roger Pau Monne wrote:
>> libaio is only required for blktap1, so make the check conditional on
>> whether the user has requested blktap1 or not.
> 
> I think it is used for blktap2 as well.

OK, I have such a mess with blktap versions and which ones are inside of
the tree. Right now configure only allows enabling/disabling blktap1,
and blktap2 is compiled depending on the host OS version. Should I
change blktap2 to be selected on configure and disabled by default?
(just like blktap1)

> I thought blktap2 was Linux specific (and hence that the libaio could be
> too) but, from tools/Makefile:
> SUBDIRS-$(CONFIG_Linux) += blktap2
> SUBDIRS-$(CONFIG_NetBSD) += blktap2
> 
> I'm totally surprised by that! And TBH I find it a little hard to
> believe...

Yes, this is certainly a mistake, NetBSD never had anything similar to
blktap2 AFAIK.

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel