Re: [Xen-devel] [PATCH v2 11/17] hotplug: add FreeBSD vif-bridge

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

On 05/06/14 17:34, Ian Campbell wrote:
> On Thu, 2014-06-05 at 17:32 +0200, Roger Pau Monnà wrote:
>> On 05/06/14 17:26, Ian Campbell wrote:
>>> On Mon, 2014-06-02 at 17:08 +0200, Roger Pau Monne wrote:
>>>> +# Parameters:
>>>> +#      $1: xenstore backend path of the vif
>>>> +#      $2: action, either "add" or "remove"
>>>
>>> On Linux path ($1) is in $XENBUS_PATH and action ($2) is the first
>>> parameter. Does libxl really call the hotplug scripts in a platform
>>> specific manner?
>>
>> Yes, hotplug scripts are platform dependant, the arguments/env variables
>> are set in libxl_{linux/netbsd/freebsd}.c,
> 
> so I (now) see :-/
> 
>>  although I wouldn't mind
>> changing the order, it seems more natural to have the action first and
>> then the backend path IMHO.
> 
> I think consistency with *bsd is more important. having three different
> ways of doing this would be madness ;-)

OK, now I see why I've done it this way, because the vif-bridge script
is a clone of the NetBSD one and follows the same order, so yes, for
consistency this should be kept as-is.

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel