Re: [Xen-devel] [PATCH 1/2] hvmloader: also cover PCI MMIO ranges above 4G with UC MTRR ranges

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Mon, 2014-05-19 at 14:12 +0100, Jan Beulich wrote:
> @@ -163,6 +176,17 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, 
>                  Add(MMIN, MLEN, MMAX)
>                  Subtract(MMAX, One, MMAX)
>  
> +                CreateQWordField(PRT0, \_SB.PCI0._CRS._Y02._MIN, HMIN)
> +                CreateQWordField(PRT0, \_SB.PCI0._CRS._Y02._MAX, HMAX)
> +                CreateQWordField(PRT0, \_SB.PCI0._CRS._Y02._LEN, HLEN)
> +
> +                Store(\_SB.HMIN, HMIN)
> +                Store(\_SB.HLEN, HLEN)
> +                Add(HMIN, HLEN, HMAX)
> +                If(LOr(HMIN, HLEN)) {
> +                    Subtract(HMAX, One, HMAX)
> +                }

This is (unlike the low version) conditional because HLEN might be 0? Is
the fact that _Y02 might continue to contain all zeroes OK?

I expect so, in which case

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

(I expect you will commit this yourself when you are ready)

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel