Re: [Xen-devel] [PATCH] libvchan: Make raw_get_{data_ready, buffer_space} match

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-05-19 at 16:21 -0400, Daniel De Graaf wrote:
> On 05/19/2014 07:31 AM, Ian Jackson wrote:
> > Jason Andryuk writes ("[PATCH] libvchan: Make 
> > raw_get_{data_ready,buffer_space} match"):
> >> For writing into a vchan, raw_get_buffer_space used >, allowing the full
> >> ring size to be written.  On the read side, raw_get_data_ready compared
> >> the ring size with >=.  This mismatch means a completely filled buffer
> >> cannot be read.  Fix this by making the size checks identical.
> >
> > This seems right to me, but I have CC'd the authors of this area of
> > code to give them a chance to comment.
> >
> > Thanks,
> > Ian.
> 
> This also looks correct to me.

Can I take that as an Acked-by frm the both of you?

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel