Re: [Xen-devel] [PATCH v7 1/4] xen/arm: p2m: Clean cache PT when the IOMMU doesn't support coherent walk

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-05-15 at 18:06 +0100, Julien Grall wrote:
> On 05/15/2014 05:04 PM, Jan Beulich wrote:
> >>>> On 15.05.14 at 16:16, <julien.grall@xxxxxxxxxx> wrote:
> >> Some IOMMU don't suppport coherent PT walk. When the p2m is shared with
> >> the CPU, Xen has to make sure the PT changes have reached the memory.
> >>
> >> Introduce new IOMMU function that will check if the IOMMU feature is 
> >> enabled
> >> for a specified domain.
> >>
> >> On ARM, the platform can contain multiple IOMMUs. Each of them may not
> >> have the same set of feature. The domain parameter will be used to get the
> >> set of features for IOMMUs used by this domain.
> >>
> >> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > 
> > IOMMU part:
> > Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Thanks. Ian, will you take care to remove the "," in this patch? It will
> avoid me to resend the whole series for this small change.

I can do, yes.

> 
> > with one final nit:
> > 
> >> --- a/xen/include/xen/iommu.h
> >> +++ b/xen/include/xen/iommu.h
> >> @@ -67,6 +67,15 @@ int iommu_map_page(struct domain *d, unsigned long gfn, 
> >> unsigned long mfn,
> >>                     unsigned int flags);
> >>  int iommu_unmap_page(struct domain *d, unsigned long gfn);
> >>  
> >> +enum iommu_feature
> >> +{
> >> +    IOMMU_FEAT_COHERENT_WALK,
> >> +    IOMMU_FEAT_count,
> 
> Regards,
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel