[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 1/4] xen/arm: p2m: Clean cache PT when the IOMMU doesn't support coherent walk

>>> On 15.05.14 at 16:16, <julien.grall@xxxxxxxxxx> wrote:
> Some IOMMU don't suppport coherent PT walk. When the p2m is shared with
> the CPU, Xen has to make sure the PT changes have reached the memory.
> Introduce new IOMMU function that will check if the IOMMU feature is enabled
> for a specified domain.
> On ARM, the platform can contain multiple IOMMUs. Each of them may not
> have the same set of feature. The domain parameter will be used to get the
> set of features for IOMMUs used by this domain.
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

IOMMU part:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

with one final nit:

> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -67,6 +67,15 @@ int iommu_map_page(struct domain *d, unsigned long gfn, 
> unsigned long mfn,
>                     unsigned int flags);
>  int iommu_unmap_page(struct domain *d, unsigned long gfn);
> +enum iommu_feature
> +{
> +    IOMMU_FEAT_count,

This is supposed to be the terminal entry, no matter what future
additions may arise. Therefore it shouldn't have a (potentially
misleading) trailing comma on it.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.