[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v10 07/19] qspinlock: Use a simple write to grab the lock, if applicable

On 05/08/2014 03:02 PM, Peter Zijlstra wrote:
On Wed, May 07, 2014 at 11:01:35AM -0400, Waiman Long wrote:
+ * get_qlock - Set the lock bit and own the lock
+ * @lock: Pointer to queue spinlock structure
+ *
+ * This routine should only be called when the caller is the only one
+ * entitled to acquire the lock.
+ */
+static __always_inline void get_qlock(struct qspinlock *lock)

+       struct __qspinlock *l = (void *)lock;
+       barrier();
+       ACCESS_ONCE(l->locked) = _Q_LOCKED_VAL;
+       barrier();
get_qlock() is just horrible. The function doesn't actually _get_
anything, and qlock is not in line with the rest of the naming.

Sure, I will make the change.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.