Re: [Xen-devel] [PATCH v10 07/19] qspinlock: Use a simple write to grab the lock, if applicable

[Peter Zijlstra <peterz@xxxxxxxxxxxxx>]

On Wed, May 07, 2014 at 11:01:35AM -0400, Waiman Long wrote:
>  /**
> + * get_qlock - Set the lock bit and own the lock
> + * @lock: Pointer to queue spinlock structure
> + *
> + * This routine should only be called when the caller is the only one
> + * entitled to acquire the lock.
> + */
> +static __always_inline void get_qlock(struct qspinlock *lock)

set_locked()

> +{
> +     struct __qspinlock *l = (void *)lock;
> +
> +     barrier();
> +     ACCESS_ONCE(l->locked) = _Q_LOCKED_VAL;
> +     barrier();
> +}

get_qlock() is just horrible. The function doesn't actually _get_
anything, and qlock is not in line with the rest of the naming.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel