Re: [Xen-devel] [PATCH linux v3] arm: xen: implement multicall hypercall support.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-09 at 17:13 +0100, Stefano Stabellini wrote:
> On Fri, 9 May 2014, Ian Campbell wrote:
> > On Fri, 2014-05-09 at 15:56 +0100, Stefano Stabellini wrote:
> > > On Mon, 28 Apr 2014, Ian Campbell wrote:
> > > > On Fri, 2014-04-25 at 18:17 +0100, Stefano Stabellini wrote:
> > > > > > > diff --git a/arch/arm64/xen/hypercall.S 
> > > > > > > b/arch/arm64/xen/hypercall.S
> > > > > > > index 531342e..8bbe940 100644
> > > > > > > --- a/arch/arm64/xen/hypercall.S
> > > > > > > +++ b/arch/arm64/xen/hypercall.S
> > > > > > > @@ -80,6 +80,7 @@ HYPERCALL2(memory_op);
> > > > > > >  HYPERCALL2(physdev_op);
> > > > > > >  HYPERCALL3(vcpu_op);
> > > > > > >  HYPERCALL1(tmem_op);
> > > > > > > +HYPERCALL2(multicall);
> > > > > > >  
> > > > > > >  ENTRY(privcmd_call)
> > > > > > >   mov x16, x0
> > > > > 
> > > > > You need to add an EXPORT_SYMBOL_GPL for it in 
> > > > > arch/arm/xen/enlighten.c.
> > > > 
> > > > HYPERVISOR_multicall is not currently exported for x86 either. I think
> > > > we should go with this existing patch and sort out the exports
> > > > consistently across arch/* in a followup.
> > > 
> > > HYPERVISOR_multicall doesn't need to be exported on x86 because it is
> > > defined as a static inline function.
> > 
> > Oh, of course.
> > 
> > Here is the fix. Feel free to fold this into the existing commit if you
> > prefer.
> > 
> > 8<-------------------------
> > 
> > >From 40542140ca071039b2c448e53d7536a3b3134028 Mon Sep 17 00:00:00 2001
> > From: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Date: Fri, 9 May 2014 16:06:21 +0100
> > Subject: [PATCH] arm: xen: export HYPERVISOR_multicall to modules.
> > 
> > "arm: xen: implement multicall hypercall support." forgot to do this.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> added to devel/for-linus-3.16

thanks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel