Re: [Xen-devel] [PATCH linux v3] arm: xen: implement multicall hypercall support.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 28 Apr 2014, Ian Campbell wrote:
> On Fri, 2014-04-25 at 18:17 +0100, Stefano Stabellini wrote:
> > > > diff --git a/arch/arm64/xen/hypercall.S b/arch/arm64/xen/hypercall.S
> > > > index 531342e..8bbe940 100644
> > > > --- a/arch/arm64/xen/hypercall.S
> > > > +++ b/arch/arm64/xen/hypercall.S
> > > > @@ -80,6 +80,7 @@ HYPERCALL2(memory_op);
> > > >  HYPERCALL2(physdev_op);
> > > >  HYPERCALL3(vcpu_op);
> > > >  HYPERCALL1(tmem_op);
> > > > +HYPERCALL2(multicall);
> > > >  
> > > >  ENTRY(privcmd_call)
> > > >         mov x16, x0
> > 
> > You need to add an EXPORT_SYMBOL_GPL for it in arch/arm/xen/enlighten.c.
> 
> HYPERVISOR_multicall is not currently exported for x86 either. I think
> we should go with this existing patch and sort out the exports
> consistently across arch/* in a followup.

HYPERVISOR_multicall doesn't need to be exported on x86 because it is
defined as a static inline function.

HYPERVISOR_multicall would need to be exported on ARM because has an
entry point in assembly.

Otherwise you can avoid exporting the symbol if you are completely sure
that the hypercall cannot and should not be made by a module but in that
case you should at the very least add a comment.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel