[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: fix cirrus vga video memory setting with upstream qemu

Il 08/05/2014 17:19, Ian Campbell ha scritto:
On Thu, 2014-05-08 at 17:03 +0200, Fabio Fantoni wrote:
Il 08/05/2014 13:33, Ian Campbell ha scritto:
On Thu, 2014-05-08 at 12:41 +0200, Fabio Fantoni wrote:

About qemu version when vgamem_mb property is added is qemu 1.3, I
already did detailed reply about it in stdvga patch:
Or you mean something other?
"in the commit message" is the bit you keep missing.
I not found 1399030886.32736.63.camel@xxxxxxxxxxxxxxxxxxxxxx with google
or thunderbird on mail archive, I not understand what post you refer :(
mid.gmane.org is a good way to find these things. e.g.:

Note that the <> which I quoted *are* part of the message id.

The questions there were:
         Is this change correct for all versions of mainline qemu which
         people might be using with Xen?

vgamem_mb property was added in qemu 1.3 (same for stdvga patch), xen 4.4 from source use qemu 1.6, and from distributions package is newer all case I saw, then FWIK there should be no problems. Xen 4.4 if I remember good change other important qemu value for hvm domUs that require qemu>=1.6. (1.6.1 because 1.6.0 have critical regression for all hvm domUs)

Please can you also explain what "wrong" means? Does it crash?
         Does it silently ignore the setting? Does it do something else
         "wrong"? How bad is it?

It silently ignore the setting.

> - with this qemu parameters seems correct but for further
         >   confirmation I posted a question about it:
         > http://lists.xen.org/archives/html/xen-devel/2014-04/msg02606.html

         Any reply to this question?

Don Slutz(who  found the problem of global parameters wrong silently ignored on 
qemu) responded:
One part of his reply is strange but he gave the reviewed-by and the patch is 
tested and working,so probably  I did not understand  that part.

The question about qemu versions is above,
As I keep saying: These questions should be answered by the *commit

  the patch is tested and on
domUs show correct video memory size, for example now I'm using windows
7 domUs with stdvga and videoram=64 and on windows in standard video
device properties show 64 mb of memory (default is 16 mb).
More information which would be useful in the commit message.

I'll add more details on commit message of this patch and also the stdvga one.

The only think that I not understand is part of latest Don Slutz reply
even if he did "Reviewed-by" on patch.

Thanks for any reply and sorry for my bad english.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.